feat(nextjs): Add browser SDK to app directory browser bundle
#6812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
lforst
force-pushed
the
lforst-app-dir-browser
branch
from
e453015 to
4c3e556
Compare
lforst
force-pushed
the
lforst-app-dir-browser
branch
from
ec7441d to
674f58e
Compare
AbhiPrasad
reviewed
Jan 17, 2023
| { | ||
| "typescript.tsdk": "node_modules/typescript/lib", | ||
| "typescript.enablePromptUseWorkspaceTsdk": true | ||
| } |
There was a problem hiding this comment.
Ah yeah. Next.js 13 seems to auto-generate this - I gitignored it.
| @@ -0,0 +1,5 @@ | |||
| 'use client'; | |||
There was a problem hiding this comment.
lol @ the fact that the nextjs api uses directives like this
| @@ -9,4 +9,4 @@ const handler = async (_req: NextApiRequest, res: NextApiResponse): Promise<void | |||
| res.status(200).json({}); | |||
| }; | |||
|
|
|||
| export default withSentry(handler); | |||
| export default wrapApiHandlerWithSentry(handler, '/api/http'); | |||
There was a problem hiding this comment.
shouldn't we be autowrapping these anyway?
There was a problem hiding this comment.
Actually yes. I removed the wrappers and everything still seems to pass 👍
AbhiPrasad
approved these changes
Jan 17, 2023
|
Sorry to bother, but can this get a publish to npm (even as a canary/beta release?). It's blocking me from tracking errors in my app directory client routes. |
|
@switz We're probably gonna release this change as part of a release on Monday. This will add client-side monitoring to the app directory. Server-side monitoring still needs some work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #6726
This PR injects the Next.js SDK into the browser code when the
appdirectory is used.Note: Pageload transactions seem to work fine. Navigation transactions don't fire yet.